server: scale wl_touch events

Fixes #172
This commit is contained in:
Shawn Wallace 2025-06-19 20:54:57 -04:00
parent b98fa84524
commit 70f15d5085
3 changed files with 114 additions and 22 deletions

View file

@ -711,29 +711,49 @@ impl Event for client::wl_keyboard::Event {
impl Event for client::wl_touch::Event {
fn handle<C: XConnection>(self, target: Entity, state: &mut ServerState<C>) {
let touch = state.world.get::<&WlTouch>(target).unwrap();
match self {
Self::Down {
serial,
time,
surface,
id,
x,
y,
} => {
let mut cmd = CommandBuffer::new();
{
let Some(mut s_query) = surface.data().copied().and_then(|key| {
state
.world
.query_one::<(&WlSurface, &SurfaceScaleFactor)>(key)
.ok()
}) else {
return;
};
let s_surf;
simple_event_shunt! {
touch, self => [
Down {
serial,
time,
|surface| {
s_surf = surface.data().copied().and_then(|key| state.world.get::<&WlSurface>(key).ok());
if let Some(s) = &s_surf { s } else { return; }
},
id,
x,
y
},
Up { serial, time, id },
Motion { time, id, x, y },
Frame,
Cancel,
Shape { id, major, minor },
Orientation { id, orientation }
]
let (s_surface, s_factor) = s_query.get().unwrap();
cmd.insert(target, (*s_factor,));
let touch = state.world.get::<&WlTouch>(target).unwrap();
touch.down(serial, time, s_surface, id, x * s_factor.0, y * s_factor.0);
}
cmd.run_on(&mut state.world);
}
Self::Motion { time, id, x, y } => {
let (touch, scale) = state.world.query_one_mut::<(&WlTouch, &SurfaceScaleFactor)>(target).unwrap();
touch.motion(time, id, x * scale.0, y * scale.0);
}
_ => {
let touch = state.world.get::<&WlTouch>(target).unwrap();
simple_event_shunt! {
touch, self => [
Up { serial, time, id },
Frame,
Cancel,
Shape { id, major, minor },
Orientation { id, orientation }
]
}
}
}
}
}

View file

@ -20,6 +20,7 @@ use wayland_client::{
wl_shm::{Format, WlShm},
wl_shm_pool::WlShmPool,
wl_surface::WlSurface,
wl_touch::{self, WlTouch},
},
Connection, Proxy, WEnum,
};
@ -2246,6 +2247,49 @@ fn transient_for_toplevel() {
);
}
#[test]
fn touch_fractional_scale() {
let mut f = TestFixture::new_pre_connect(|testwl| {
testwl.enable_fractional_scale();
});
let comp = f.compositor();
let (_, output) = f.new_output(0, 0);
let touch = TestObject::<WlTouch>::from_request(&comp.seat.obj, wl_seat::Request::GetTouch {});
f.run();
let toplevel = unsafe { Window::new(1) };
let (_, id) = f.create_toplevel(&comp, toplevel);
f.testwl.move_surface_to_output(id, &output);
let data = f.testwl.get_surface_data(id).unwrap();
let server_surface = data.surface.clone();
let fractional = data.fractional.as_ref().cloned().unwrap();
let do_touch = |f: &mut TestFixture, x, y| {
f.testwl.touch().down(0, 0, &server_surface, 0, x, y);
f.testwl.dispatch();
f.run();
f.run();
let events = &mut touch.data.events.lock().unwrap();
assert_eq!(events.len(), 1);
let event = events.pop().unwrap();
let wl_touch::Event::Down { x, y, .. } = event else {
panic!("Got unexpected event: {event:?}");
};
(x, y)
};
let (x, y) = do_touch(&mut f, 20.0, 40.0);
assert_eq!(x, 20.0);
assert_eq!(y, 40.0);
fractional.preferred_scale(180); // 1.5 scale
f.run();
let (x, y) = do_touch(&mut f, 20.0, 40.0);
assert_eq!(x, 20.0 * 1.5);
assert_eq!(y, 40.0 * 1.5);
}
/// See Pointer::handle_event for an explanation.
#[test]
fn popup_pointer_motion_workaround() {}