Cleanup last few build details

Signed-off-by: falkTX <falktx@falktx.com>

.github/workflows/build.yml

@@ -417,7 +417,7 @@ jobs:
       - name: Set up dependencies
         run: |
           ./deps/PawPaw/.github/workflows/bootstrap-deps.sh ${{ matrix.target }}
-          apt-get install -yqq wget zip
+          apt-get install -yqq wget xvfb zip
           apt-get clean
       - name: Set up ccache
         uses: hendrikmuhs/ccache-action@v1.2
@@ -458,6 +458,7 @@ jobs:
         run: echo "SHA8=$(echo ${{ github.ref_name }})" >> $GITHUB_ENV
       - name: Pack binaries
         if: steps.cache.outputs.cache-hit == 'true'
+        shell: bash
         run: |
           pushd bin
           zip -r -9 ../${{ github.event.repository.name }}-${{ matrix.target }}-${{ github.event.pull_request.number || env.SHA8 }}.zip $(ls | grep -e lv2 -e vst -e clap)

Makefile

@@ -268,9 +268,6 @@ clean:
 	$(MAKE) clean -C plugins
 	$(MAKE) clean -C src
 	rm -rf bin build build-headless dpf/utils/lv2_ttl_generator.d
-	# FIXME
-	rm -f src/Rack/BaconMusic/default-skin.json
-	rm -f src/Rack/SurgeXTRack/default-skin.json
 
 # --------------------------------------------------------------
 # Install step

Makefile.base.mk

@@ -73,7 +73,7 @@ BASE_FLAGS += -msse -msse2 -msse3 -msimd128
 else ifeq ($(CPU_ARM32),true)
 BASE_FLAGS += -mfpu=neon-vfpv4 -mfloat-abi=hard
 else ifeq ($(CPU_I386_OR_X86_64),true)
-BASE_FLAGS += -msse -msse2 -msse3 -mfpmath=sse
+BASE_FLAGS += -msse -msse2 -msse3
 endif
 
 ifeq ($(SYSDEPS),true)

deps/Makefile

@@ -335,6 +335,12 @@ clean:
 	rm -rf $(RACK_DEP_PATH)/jansson-2.12
 	rm -rf $(RACK_DEP_PATH)/libarchive-3.4.3
 	rm -rf $(RACK_DEP_PATH)/libsamplerate-0.1.9
+	rm -rf $(RACK_DEP_PATH)/speexdsp/autom4te.cache
+	rm -rf $(RACK_DEP_PATH)/speexdsp/libspeexdsp/.deps
+	rm -rf $(RACK_DEP_PATH)/speexdsp/libspeexdsp/.libs
+	rm -rf $(RACK_DEP_PATH)/speexdsp/libspeexdsp/*.lo
+	rm -rf $(RACK_DEP_PATH)/speexdsp/libspeexdsp/*.o
+	rm -rf $(RACK_DEP_PATH)/speexdsp/Makefile
 	rm -rf $(RACK_DEP_PATH)/zstd-1.4.5
 	rm -rf $(SURGE_DEP_PATH)
 

include/simd-compat/emmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_SSE2_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_SSE2_NATIVE)
 # include_next <emmintrin.h>
 #else
 # include "mmintrin.h"

include/simd-compat/immintrin.h

@@ -9,7 +9,9 @@
 #include "simd-compat.h"
 
 #ifdef SIMDE_X86_SSE_NATIVE
+# define CARDINAL_INCLUDING_IMMINTRIN_H
 # include_next <immintrin.h>
+# undef CARDINAL_INCLUDING_IMMINTRIN_H
 #else
 # include "mmintrin.h"
 # include "xmmintrin.h"

include/simd-compat/mmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_MMX_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_MMX_NATIVE)
 # include_next <mmintrin.h>
 #else
 # define SIMDE_ENABLE_NATIVE_ALIASES

include/simd-compat/pmmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_SSE3_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_SSE3_NATIVE)
 # include_next <pmmintrin.h>
 #else
 # include "mmintrin.h"

include/simd-compat/simd-compat.h

@@ -50,3 +50,17 @@
 #  define SIMDE_WASM_SIMD128_NATIVE
 # endif
 #endif
+
+// fix win32 build
+#ifdef _WIN32
+static inline
+float simde_math_roundevenf(float v) {
+    float rounded = __builtin_roundf(v);
+    float diff = rounded - v;
+    if (__builtin_expect(!!(__builtin_fabsf(diff) == 0.5f) && ((int)rounded & 1), 0)) {
+        rounded = v - diff;
+    }
+    return rounded;
+}
+#define simde_math_roundevenf simde_math_roundevenf
+#endif

include/simd-compat/smmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_SSE4_1_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_SSE4_1_NATIVE)
 # include_next <smmintrin.h>
 #else
 # include "mmintrin.h"

include/simd-compat/tmmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_SSSE3_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_SSSE3_NATIVE)
 # include_next <tmmintrin.h>
 #else
 # include "mmintrin.h"

include/simd-compat/xmmintrin.h

@@ -8,7 +8,7 @@
 
 #include "simd-compat.h"
 
-#ifdef SIMDE_X86_SSE_NATIVE
+#if defined(CARDINAL_INCLUDING_IMMINTRIN_H) || defined(SIMDE_X86_SSE_NATIVE)
 # include_next <xmmintrin.h>
 #else
 # include "mmintrin.h"

src/override/common.cpp

@@ -1,18 +1,7 @@
 /*
  * DISTRHO Cardinal Plugin
- * Copyright (C) 2021-2023 Filipe Coelho <falktx@falktx.com>
+ * Copyright (C) 2021-2024 Filipe Coelho <falktx@falktx.com>
- *
+ * SPDX-License-Identifier: GPL-3.0-or-later
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of
- * the License, or any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * For a full copy of the GNU General Public License see the LICENSE file.
  */
 
 /**
@@ -63,7 +52,7 @@ const std::string APP_NAME = "Cardinal";
 const std::string APP_EDITION = getPluginFormatName();
 const std::string APP_EDITION_NAME = "Audio Plugin";
 const std::string APP_VERSION_MAJOR = "2";
-const std::string APP_VERSION = "2.3.0";
+const std::string APP_VERSION = "2.4.1";
 #if defined ARCH_WIN
 	const std::string APP_OS = "win";
 #elif defined ARCH_MAC