From 87d6e4eeceb27a4ad62238d60f34eeb5e352c010 Mon Sep 17 00:00:00 2001 From: Don Cross Date: Fri, 30 May 2025 22:26:51 -0400 Subject: [PATCH] Sapphire v2.5.9 - new module Echo (#832) * Sapphire v2.5.9 - new module Echo Added a new multitap delay module: [Echo](https://github.com/cosinekitty/sapphire/blob/main/doc/Echo.md). Added "neon mode" menu options to make the Sapphire panel glow. This effect is most visible when the room brightness is dim. Chaops did not reset the FREEZE button on initialize. This has been fixed. Fixed minor polyphony bug in Env: the number of channels in the GAIN control's CV input did not affect the number of output channels. This has been fixed. Fixed typos in help text for Gravy and Sauce. * Sapphire v2.5.9 attempt 2: fixed memory errors * Sapphire v2.5.9 - fixed build problem for Windows. There was a compatibility problem between MINGW and my own member function named `format`. I don't need MINGW so I disabled it in the Cardinal Makefile. This solution was suggested by @falkTX. It is nice because I don't have to change any Sapphire code! --- plugins/Makefile | 1 + plugins/Sapphire | 2 +- plugins/plugins.cpp | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/Makefile b/plugins/Makefile index 53042ba..b975411 100644 --- a/plugins/Makefile +++ b/plugins/Makefile @@ -2763,6 +2763,7 @@ $(BUILD_DIR)/Sapphire/%.cpp.o: Sapphire/%.cpp @echo "Compiling $<" $(SILENT)$(CXX) $< $(BUILD_CXX_FLAGS) -std=gnu++17 -c -o $@ \ $(foreach m,$(SAPPHIRE_CUSTOM),$(call custom_module_names,$(m),Sapphire)) \ + -DSKIP_MINGW_FORMAT \ -DpluginInstance=pluginInstance__sapphire $(BUILD_DIR)/sonusmodular/%.cpp.o: sonusmodular/%.cpp diff --git a/plugins/Sapphire b/plugins/Sapphire index c65bf21..a1f7deb 160000 --- a/plugins/Sapphire +++ b/plugins/Sapphire @@ -1 +1 @@ -Subproject commit c65bf21e00c984613749ce76ba07633f3eb8d61f +Subproject commit a1f7deb7931b7ef0fc4fa9f8a3871d9e37e81e73 diff --git a/plugins/plugins.cpp b/plugins/plugins.cpp index 1ed3649..45c0f52 100644 --- a/plugins/plugins.cpp +++ b/plugins/plugins.cpp @@ -3213,6 +3213,9 @@ static void initStatic__Sapphire() if (spl.ok()) { p->addModel(modelSapphireChaops); + p->addModel(modelSapphireEcho); + p->addModel(modelSapphireEchoOut); + p->addModel(modelSapphireEchoTap); p->addModel(modelSapphireElastika); p->addModel(modelSapphireEnv); p->addModel(modelSapphireFrolic);