brian/xevi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Upper bound on length of version string for sysex message

Browse source
This commit is contained in:
John Stäck 2019-08-15 08:04:41 +02:00
parent 660d6583b3
commit 9e76cfbdde
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
NuEVI/settings.cpp
View file

@ -367,13 +367,14 @@ bool receiveSysexSettings(const uint8_t* data, const uint16_t length) {
//Send EEPROM and firmware versions //Send EEPROM and firmware versions
void sendSysexVersion() { void sendSysexVersion() {
char sysexMessage[] = "vvvNuEVIc04eevvvvvvvv"; //Placeholders for vendor and code char sysexMessage[] = "vvvNuEVIc04eevvvvvvvv"; //Placeholders for vendor and code
uint8_t fwStrLen = min(strlen(FIRMWARE_VERSION), 8); //Limit firmware version string to 8 bytes
memcpy(sysexMessage, sysex_id, 3); memcpy(sysexMessage, sysex_id, 3);
memcpy(sysexMessage+13, FIRMWARE_VERSION, min(strlen(FIRMWARE_VERSION), 8)); memcpy(sysexMessage+13, FIRMWARE_VERSION, fwStrLen);
*(uint16_t*)(sysexMessage+11) = convertToMidiValue(EEPROM_VERSION); *(uint16_t*)(sysexMessage+11) = convertToMidiValue(EEPROM_VERSION);
uint8_t message_length = 13+strlen(FIRMWARE_VERSION); uint8_t message_length = 13+fwStrLen;
usbMIDI.sendSysEx(message_length, (const uint8_t *)sysexMessage); usbMIDI.sendSysEx(message_length, (const uint8_t *)sysexMessage);
} }