From f5211800d01f2eae44a45c3809bd6bf2c7685fa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20St=C3=A4ck?= Date: Sat, 2 Mar 2019 09:49:36 +0100 Subject: [PATCH] Constrain unconstrained non-use of constrain() --- NuEVI.ino | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/NuEVI.ino b/NuEVI.ino index beb8e28..0e914ac 100644 --- a/NuEVI.ino +++ b/NuEVI.ino @@ -724,12 +724,8 @@ void loop() { if (!K1 && !K2 && K3 && !K4) { //send reverb pitchlatch value reverb = ((pitchlatch - 36) * 2); - if (reverb > 127) { - reverb = 127; - } - if (reverb < 0) { - reverb = 0; - } + reverb = constrain(reverb, 0, 127); + midiSendControlChange(91, reverb); } } @@ -1145,9 +1141,7 @@ int noteValueCheck(int note) { //************************************************************** int patchLimit(int value) { - if (value < 1) return 1; - else if (value > 128) return 128; - else return value; + return constrain(value, 1, 128); } //**************************************************************